Born Edinburgh, he studied at the Edinburgh School of Design, the RSA schools and Academie Julian Paris. He started as a Lithographic draughtsman but soon turned to painting. His work included portraits, landscapes and views of Edinburgh in oil. Associated wit the East Linton group of painters and most of his landscapes are of East Linton. He was in addition a muralist and book illustrator.